Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples/supply-chain-app): fix resource cleanup of shutdown logic #3364

Conversation

petermetz
Copy link
Contributor

  1. Now you can run the supply chain app example locally and then hit CTRL+C
    on the terminal and it will gracefully shut down all the containers hosting
    the infrastructure and only after that the NodeJS process itself will exit.
  2. Previously we had a bug where it wouldn't wait for the containers to wind
    down and it left them running which was causing problems when people didn't
    notice this behavior and their machines would get into this broken state where
    the previous execution's containers were hanging around and one of them blocking
    ports too.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

1. Now you can run the supply chain app example locally and then hit CTRL+C
on the terminal and it will gracefully shut down all the containers hosting
the infrastructure and only after that the NodeJS process itself will exit.
2. Previously we had a bug where it wouldn't wait for the containers to wind
down and it left them running which was causing problems when people didn't
notice this behavior and their machines would get into this broken state where
the previous execution's containers were hanging around and one of them blocking
ports too.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the docs-example-supply-chain-app-fix-shutdown-ctrl-c-resource-cleanup branch from 08944a0 to d6de982 Compare July 2, 2024 18:50
@petermetz petermetz merged commit eaba573 into hyperledger-cacti:main Jul 2, 2024
149 of 151 checks passed
@petermetz petermetz deleted the docs-example-supply-chain-app-fix-shutdown-ctrl-c-resource-cleanup branch July 2, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants